fix(v9/astro): Revert Astro v5 storing route data to globalThis
#17185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chargome
approved these changes
Jul 28, 2025
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To share the route data from build-time with the server runtime, the data was written on
globalThis. However, this resulted in actually modifying the server config of the working directory and not the build directory (distfolder).This PR reverts this change for now, resulting in not having all server requests parametrized. We still do have some parametrization, as route parametrization was recently improved for Astro v4 as well (without the
'astro:routes:resolved'hook)Fixes #17179